Marker RGB Colors#2023
Conversation
Signed-off-by: Spencer Magnusson <spencer.magnusson@dreamworks.com>
78d9430 to
f071e02
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2023 +/- ##
==========================================
+ Coverage 84.50% 84.76% +0.25%
==========================================
Files 181 181
Lines 13225 13263 +38
Branches 1202 1209 +7
==========================================
+ Hits 11176 11242 +66
+ Misses 1866 1838 -28
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
f071e02 to
6b21be5
Compare
Signed-off-by: Spencer Magnusson <spencer.magnusson@dreamworks.com>
6b21be5 to
19736ec
Compare
|
Hey @semagnum, thank you, this is a great addition. The code looks good, but I am wondering how to best approach the release of this change, since some adapters are likely using the marker color and expecting it to be a string value. We might have to do pass over the common adapters, check where we need to do some changes. @apetrynet can you assign the devdays26 badge on this? |
Fixes #1873
Summarize your change.
Part of ASWF Dev Days 2026. Removes redundant
Marker::Colorenum and replaces it with the standardColorclass recently added for metadata.Marker::Colorand itsstd::string _colorattribute with an optionalColorequivalent (defaults kept the same)Markerto schema 3Marker::Colorenum names, it converts it to theColorequivalent. Otherwise, it preserves the original nameColorname matches any of theMarker::Colorenum names, it renames it to the all-caps name. Otherwise, it preserves the original nameMarkerColorPython name to useColor. We can mark the name for deprecation in the future, but I figured this would be helpful for backwards compatibility for now!=operator forColorclass, binds the equality functionality into PythonReference associated tests.
test_marker.pytests, added a test for upgrading schema to 3test_clip.cpp,test_clip.py,test_console.pythat references marker colors